fix: commitments/by-index/:index/blocks route should return only finalized blocks
#1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
force-pushed
the
fetch-finalized-blocks-in-explorer
branch
from
67ebdb9 to
343285b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the explorer route
commitments/by-index/:index/blocksblocks are already shown, when they are justaccepted, but not yetfinalized. This PR generalizes the corresponding routes handler (that forwards the query to MongoDb) to additionally provide the block state. For the Explorer API specifically that means, that the handler internally sets the addedblock_stateparameter toSome(BlockState::Finalized).We could also not do it like this, but instead make this mongodb query specific to finalized blocks, but then it would be specifc to the explorer api which I didn't like that much, but I am open to change it if wanted.
UPDATE: this PR was changed to only store blocks if and when they are finalized. Hence, we removed the corresponding block state analytic.